Skip to content

Creating pull request for 10.21105.joss.02689 #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

whedon
Copy link
Contributor

@whedon whedon commented Dec 9, 2020

If this looks good then :shipit:

Copy link

@d-tear d-tear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PDF looks good.

However, line 52 of the crossref.xml should be <given_name>J. Andrew</given_name>
First name is John, but this author writes their name as J. Andrew MacKay.

Otherwise everything looks good!

<surname>Lei</surname>
</person_name>
<person_name sequence="additional" contributor_role="author">
<given_name>J.</given_name>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be J. Andrew. First name is John, but this author writes their name as J. Andrew MacKay.

@whedon whedon closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants