8361249: PlainHttpConnection connection logic can be simplified

[dfuch]

The PlainHttpConnection::connectAsync method implements a retry logic that will call connect() again if connect() throws the first time. This will not work, as the channel is closed when connect() throws. That logic should be removed. Reconnection should only be attempted at a higher level (MultiExchange).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361249: PlainHttpConnection connection logic can be simplified (Bug - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Volkan Yazici (@vy - Committer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26087/head:pull/26087
$ git checkout pull/26087

Update a local copy of the PR:
$ git checkout pull/26087
$ git pull https://git.openjdk.org/jdk.git pull/26087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26087

View PR using the GUI difftool:
$ git pr show -t 26087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26087.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361249: PlainHttpConnection connection logic can be simplified

Reviewed-by: djelinski, vyazici, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• f2d2eef: 8177100: APIs duplicated in JavaDoc
• 1c56072: 8360775: Fix Shenandoah GC test failures when APX is enabled
• f153e41: 8361253: CommandLineOptionTest library should report observed values on failure
• ... and 36 more: https://git.openjdk.org/jdk/compare/0f1cd987b3520eaeab31e9faf782d6f81050803a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (12ba2924)
• 01: Full - Incremental (a63206df)
• 00: Full (58c78e57)

[Michael-Mc-Mahon]

I think this code was added to deal with https://bugs.openjdk.org/browse/JDK-8256459. Did the change not fix that problem? Or did that change include the changes to MultiExchange you mention above?

[dfuch]

I think this code was added to deal with https://bugs.openjdk.org/browse/JDK-8256459. Did the change not fix that problem? Or did that change include the changes to MultiExchange you mention above?

The change did not include changes to the multi exchange but it included changes to the tests themselves.
I fail to see how calling connect() again on the same channel could have solved the issue: I verified by code inspection that the channel is closed when connect() fails - and calling connect() again simply generates a ClosedChannelException.