Skip to content

Update ConcurrentHashMap.java #24612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cdw200806
Copy link

@cdw200806 cdw200806 commented Apr 13, 2025

"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24612/head:pull/24612
$ git checkout pull/24612

Update a local copy of the PR:
$ git checkout pull/24612
$ git pull https://git.openjdk.org/jdk.git pull/24612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24612

View PR using the GUI difftool:
$ git pr show -t 24612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24612.diff

"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2025

Hi @cdw200806, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user cdw200806" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@cdw200806
Copy link
Author

cdw200806 commented Apr 13, 2025 via email

@openjdk
Copy link

openjdk bot commented Apr 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 13, 2025

@cdw200806 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@cdw200806
Copy link
Author

cdw200806 commented Apr 13, 2025

/signed
I have signed oca. But maybe the reviewer has not handle it yet.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Apr 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@liach
Copy link
Member

liach commented Apr 13, 2025

Makes sense. Since this is assertion code, there is really no way to add a test...

@cdw200806
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2025

Already processed the signed command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants