8353655: Clean up and open source KeyEvent related tests (Part 1) #24609
Conversation
Clean up and open source three tests related to the KeyEvent mechanics.
|
👋 Welcome back kizune! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@azuev-java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| .build() | ||
| .awaitAndCheck(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Blank line after this ?
| /* | ||
| * @test | ||
| * @bug 4308606 | ||
| * @summary Tests whether the keys on the numeric keyboard work |
There was a problem hiding this comment.
| * @summary Tests whether the keys on the numeric keyboard work | |
| * @summary Tests whether the keys on the numeric keyboard work |
| case KeyEvent.KEY_TYPED: | ||
| str = "KEY_TYPED"; | ||
| break; |
There was a problem hiding this comment.
printKey is not invoked from keyTyped method and this case statement won't be reachable. Can be removed safely.
| } | ||
|
|
||
| protected void printKey(KeyEvent evt) { | ||
| switch(evt.getID()) { |
There was a problem hiding this comment.
| switch(evt.getID()) { | |
| switch (evt.getID()) { |
|
|
||
| protected void printKey(KeyEvent evt) { | ||
| String str; | ||
| switch(evt.getID()) { |
There was a problem hiding this comment.
| switch(evt.getID()) { | |
| switch (evt.getID()) { |
Clean up and open source three tests related to the KeyEvent mechanics.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24609/head:pull/24609$ git checkout pull/24609Update a local copy of the PR:
$ git checkout pull/24609$ git pull https://git.openjdk.org/jdk.git pull/24609/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24609View PR using the GUI difftool:
$ git pr show -t 24609Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24609.diff
Using Webrev
Link to Webrev Comment