Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353485: Jcms should allow to specify streaming_output mode #24494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Apr 7, 2025

The fix adds --streaming_output jcmd option to manage attach command streaming output.

Testing: tier1..tier4,hs-tier5-svc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353485: Jcms should allow to specify streaming_output mode (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24494/head:pull/24494
$ git checkout pull/24494

Update a local copy of the PR:
$ git checkout pull/24494
$ git pull https://git.openjdk.org/jdk.git pull/24494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24494

View PR using the GUI difftool:
$ git pr show -t 24494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24494.diff

Using Webrev

Link to Webrev Comment

@alexmenkov alexmenkov changed the title 8353485: Jcms should allow to specify streaming_output mode 8353485: Jcms should allow to specify streaming_output mode1 Apr 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2025

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@alexmenkov The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@alexmenkov
Copy link
Author

/label remove core-lib

@alexmenkov
Copy link
Author

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@alexmenkov
The label core-lib is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@alexmenkov
The core-libs label was successfully removed.

@alexmenkov alexmenkov changed the title 8353485: Jcms should allow to specify streaming_output mode1 8353485: Jcms should allow to specify streaming_output mode Apr 7, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant