8353332: Test jdk/jshell/ToolProviderTest.java failed in relation to enable-preview

[lahodaj]

JShell keeps persisted preferences in java.util.prefs.Preferences. But, during tests, an empty persistence is typically used, to avoid values persisted on the test machine to affect the test.

But, in case of jdk/jshell/ToolProviderTest.java, this is not done, as JShell is started using the Tool interface.

This patch strives to fix that, by adding indirection in building JShell in JShellToolProvider, and using that in the test to inject empty persistence.

Thanks to @jaikiran for figuring out the probable cause.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353332: Test jdk/jshell/ToolProviderTest.java failed in relation to enable-preview (Bug - P3)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24492/head:pull/24492
$ git checkout pull/24492

Update a local copy of the PR:
$ git checkout pull/24492
$ git pull https://git.openjdk.org/jdk.git pull/24492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24492

View PR using the GUI difftool:
$ git pr show -t 24492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24492.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353332: Test jdk/jshell/ToolProviderTest.java failed in relation to enable-preview

Reviewed-by: jpai, asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• fda5eec: 8353669: IGV: dump OOP maps for MachSafePoint nodes
• ea07e71: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path
• 9844c1c: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources
• ... and 18 more: https://git.openjdk.org/jdk/compare/9a391f44e038d6c15a7872164bd3099edad93c8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f8c5bbc6)

[jaikiran]

I don't have knowledge of this area, but given what seems to be happening in this test and the code that I looked through briefly, this proposed change to provide a way for augmenting the building of the JshellTool seems reasonable to me.

I'll update the JBS issue once the CI runs that I've triggered (without this change) come back. That should tell us if local stored preferences is (the only thing) that's playing a role in these failures.

[jaikiran]

This looks OK to me. I think it would be good to have someone more familiar with this area review this too.

[asotona]

Looks good to me.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 9088afc4f16b6265e640bf176d8ca8e3ac6ca45c.
Since your change was applied there have been 21 commits pushed to the master branch:

• fda5eec: 8353669: IGV: dump OOP maps for MachSafePoint nodes
• ea07e71: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path
• 9844c1c: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources
• ... and 18 more: https://git.openjdk.org/jdk/compare/9a391f44e038d6c15a7872164bd3099edad93c8d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 9088afc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.