Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351152: x86: Remove code blocks that handle UseSSE < 2 #24484

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 7, 2025

WIP.

32-bit x86 was the platform that supported UseSSE < 2. 64-bit x86 baselines on UseSSE >= 2. After 32-bit x86 code is gone, we can remove all code blocks that are there to support UseSSE < 2.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351152: x86: Remove code blocks that handle UseSSE < 2 (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24484/head:pull/24484
$ git checkout pull/24484

Update a local copy of the PR:
$ git checkout pull/24484
$ git pull https://git.openjdk.org/jdk.git pull/24484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24484

View PR using the GUI difftool:
$ git pr show -t 24484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24484.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant