-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282493: Add --with-jcov-modules convenience option #24481
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 67 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@shurymury I believe you are the one that originally requested this functionality. (The JBS issue is opened by me and does not mention you, but I think I created it after an offline conversation with you). Can you please have a look at this, and verify that it works like intended? |
Allow the user to set "--with-jcov-modules=java.desktop", instead of "--with-jcov-filters=--include-modules java.desktop", since this is one of the common use cases for the filtering.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24481/head:pull/24481
$ git checkout pull/24481
Update a local copy of the PR:
$ git checkout pull/24481
$ git pull https://git.openjdk.org/jdk.git pull/24481/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24481
View PR using the GUI difftool:
$ git pr show -t 24481
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24481.diff
Using Webrev
Link to Webrev Comment