Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282493: Add --with-jcov-modules convenience option #24481

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 7, 2025

Allow the user to set "--with-jcov-modules=java.desktop", instead of "--with-jcov-filters=--include-modules java.desktop", since this is one of the common use cases for the filtering.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282493: Add --with-jcov-modules convenience option (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24481/head:pull/24481
$ git checkout pull/24481

Update a local copy of the PR:
$ git checkout pull/24481
$ git pull https://git.openjdk.org/jdk.git pull/24481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24481

View PR using the GUI difftool:
$ git pr show -t 24481

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24481.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 7, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282493: Add --with-jcov-modules convenience option

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@magicus magicus marked this pull request as ready for review April 8, 2025 18:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2025
@magicus
Copy link
Member Author

magicus commented Apr 8, 2025

@shurymury I believe you are the one that originally requested this functionality. (The JBS issue is opened by me and does not mention you, but I think I created it after an offline conversation with you).

Can you please have a look at this, and verify that it works like intended?

@mlbridge
Copy link

mlbridge bot commented Apr 8, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants