8352687: Opensource few JInternalFrame and JTextField tests #24474
Conversation
|
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
|
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 303 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| JDesktopPane jdp = new JDesktopPane(); | ||
| fr.getContentPane().add(jdp); | ||
|
|
||
| JInternalFrame jif = new JInternalFrame("Title", true, true, true, true); |
There was a problem hiding this comment.
| JInternalFrame jif = new JInternalFrame("Title", true, true, true, true); | |
| JInternalFrame jif = new JInternalFrame("Title", true, true, true, true); |
| Add and remove iconify/maximize/close buttons using the buttons | ||
| "Iconifiable", "Maximizable", "Closable" under different LookAndFeels. | ||
| If they appears and disappears correctly then test passes. If any | ||
| button not appear or disappear as expected or appear with incorrect |
There was a problem hiding this comment.
| button not appear or disappear as expected or appear with incorrect | |
| button does not appear or disappear as expected or appear with incorrect |
| "</form> </body> </html>"; | ||
| e = new JEditorPane("text/html", html); | ||
| e.setEditable(false); | ||
| frame.getContentPane().add(e); |
There was a problem hiding this comment.
| frame.getContentPane().add(e); | |
| frame.add(e); |
| } | ||
|
|
||
| private static JFrame createTestUI() { | ||
|
|
There was a problem hiding this comment.
Extra line can be removed
| Click into the text field so that caret appears inside. | ||
| The caret should be placed slightly off text field borders, | ||
| so that it can be easily distinguished from the border. | ||
| Test fails if the caret touches the border."""; |
There was a problem hiding this comment.
Just a thought: Would it be good to extend this test to all platforms (getSystemLookAndFeelClassName()) since it verifies if caret does not merge with the text field border?
Few JInternalFrame and JTextField tests are opensourced
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24474/head:pull/24474$ git checkout pull/24474Update a local copy of the PR:
$ git checkout pull/24474$ git pull https://git.openjdk.org/jdk.git pull/24474/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24474View PR using the GUI difftool:
$ git pr show -t 24474Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24474.diff
Using Webrev
Link to Webrev Comment