8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number

[rk-kmr]

scanByte throws NumberFormatException for URIs that start with numbers, e.g., https://11111111.x.y/
The current flow is parseIPv4Address → scanIPv4Address → scanByte. parseIPv4Address uses NumberFormatException for control flow, so it captures the exception, ignores it, and returns -1. This has been reported by AWS customer to cause low performance. Details: JDK-8353013 & aws/aws-sdk-java-v2#5933

This PR avoids NumberFormatException by skipping calls to Integer.parseInt if the number of digits in the octet is > 3.

I benchmarked on local machine for potential regressions.
https://gist.github.com/rk-kmr/cb1a3d59225c17b180a29cc125ebf887

Benchmark                                     Mode     Cnt        Score       Error   Units
URIBenchMark.newImplWithNormalUrl            thrpt      10        0.004 ±     0.001  ops/ns
URIBenchMark.newImplWithNumberlUrl           thrpt      10        0.004 ±     0.001  ops/ns
URIBenchMark.oldImplWithNormalUrl            thrpt      10        0.004 ±     0.001  ops/ns
URIBenchMark.oldImplWithNumUrl               thrpt      10        0.001 ±     0.001  ops/ns
URIBenchMark.newImplWithNormalUrl             avgt      10      236.762 ±     8.700   ns/op
URIBenchMark.newImplWithNumberlUrl            avgt      10      264.017 ±     7.274   ns/op
URIBenchMark.oldImplWithNormalUrl             avgt      10      233.853 ±     6.539   ns/op
URIBenchMark.oldImplWithNumUrl                avgt      10     1183.572 ±    29.242   ns/op

I ran following tests.

make test-tier1
make test-tier2
make test TEST=jdk/java/net

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number (Bug - P4)

Reviewers

• Xiaolong Peng (@pengxiaolong - Author) 🔄 Re-review required (review applies to 45fb1759)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24295/head:pull/24295
$ git checkout pull/24295

Update a local copy of the PR:
$ git checkout pull/24295
$ git pull https://git.openjdk.org/jdk.git pull/24295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24295

View PR using the GUI difftool:
$ git pr show -t 24295

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24295.diff

[bridgekeeper]

Hi @rk-kmr, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rk-kmr" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@rk-kmr The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[rk-kmr]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[pengxiaolong]

Looks good to me, thanks.

[myankelev]

Could you please also add a test for this change/ add a bug id to the existing test if there already is one covering this functionality. Just in case

[rk-kmr]

Thanks! I have added unit test.