Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plaid-mapper #307

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix plaid-mapper #307

merged 1 commit into from
Mar 7, 2025

Conversation

openint-bot
Copy link
Collaborator

@openint-bot openint-bot commented Mar 7, 2025

Important

Fix delimiter in bank_category field in transaction mapper in mapper.ts to use '/'.

  • Behavior:
    • Change delimiter in bank_category field in transaction mapper from empty string to '/'.
    • Affects how personal_finance_category fields are joined when not null.

This description was created by Ellipsis for a2c6434. It will automatically update as commits are pushed.

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openint 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 6:43pm

Copy link

recurseml bot commented Mar 7, 2025

✨ No issues found! Your code is sparkling clean! ✨

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a2c6434 in 32 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. unified/unified-accounting/adapters/plaid-adapter/mapper.ts:55
  • Draft comment:
    Using join('/') improves readability compared to join(''), but consider trimming category values in case of extra whitespace.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. unified/unified-accounting/adapters/plaid-adapter/mapper.ts:56
  • Draft comment:
    Using '/' as the join delimiter in bank_category now clearly separates the primary and detailed category values. This fix improves readability and seems to be the intended behavior.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, praising the use of '/' as a delimiter. It doesn't provide any actionable feedback or suggestions for improvement.

Workflow ID: wflow_E4K89vmhw5L1vXcu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@openint-bot openint-bot merged commit a2c6434 into main Mar 7, 2025
8 of 9 checks passed
@openint-bot openint-bot deleted the fix-sync branch March 7, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant