-
Notifications
You must be signed in to change notification settings - Fork 8
Drive filepicker UI completion #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to c0b14e6 in 2 minutes and 3 seconds
More details
- Looked at
323
lines of code in14
files - Skipped
2
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. apps/web/package.json:29
- Draft comment:
Dependency version updated from^0.0.19
to^0.0.22
. Ensure compatibility with the rest of the codebase. - Reason this comment was not posted:
Confidence changes required:20%
The update to the@opensdks/fetch-links
dependency version is consistent across multiple package.json files. This is a straightforward version bump, and there are no apparent issues with this change.
2. connectors/connector-google/def.ts:10
- Draft comment:
Addedclient_id
tozSettings
. Ensure this is used consistently across the codebase. - Reason this comment was not posted:
Confidence changes required:20%
The addition ofclient_id
to thezSettings
schema is consistent with the changes in the server.ts file whereclient_id
is used. This change seems intentional and necessary for the functionality.
3. connectors/connector-google/server.ts:169
- Draft comment:
Addedclient_id
to settings inpostConnect
. Ensure this is consistent with schema changes. - Reason this comment was not posted:
Confidence changes required:20%
Theclient_id
is being added to the settings object in thepostConnect
function. This aligns with the schema changes indef.ts
. The change seems intentional and necessary for the functionality.
4. kits/file-picker/src/pickers/google/GoogleDrivePicker.tsx:109
- Draft comment:
UI rendering removed, returning null. Verify this aligns with intended functionality. - Reason this comment was not posted:
Confidence changes required:50%
The removal of UI rendering inGoogleDrivePicker
and returning null is a significant change. This should be verified to ensure it aligns with the intended functionality of the component.
Workflow ID: wflow_YYWDbOPnPpvArcXi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6d4c770 in 11 seconds
More details
- Looked at
69
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_3BMic0i3F7c8i1cd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Enhance Google Drive picker functionality and update dependencies across multiple packages.
client_id
support indef.ts
andserver.ts
for Google Drive connections.GoogleDrivePicker.tsx
to handle file and folder selection withfileMapper()
andpersistSelectedFilesOnConnection()
.GoogleDrivePicker.tsx
, returningnull
instead.@opensdks/fetch-links
to^0.0.22
inpackage.json
files forweb
,connector-plaid
,loopback-link
,cdk
,vdk
, andapi
.@opensdks/sdk-openint
to^0.1.15
infile-picker/package.json
.calendar.tsx
fromfile-picker/src/components/ui/
.This description was created by
for 6d4c770. It will automatically update as commits are pushed.