Skip to content

Drive filepicker UI completion #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Drive filepicker UI completion #241

merged 5 commits into from
Jan 27, 2025

Conversation

pellicceama
Copy link
Collaborator

@pellicceama pellicceama commented Jan 27, 2025

Important

Enhance Google Drive picker functionality and update dependencies across multiple packages.

  • Google Drive Picker:
    • Add client_id support in def.ts and server.ts for Google Drive connections.
    • Update GoogleDrivePicker.tsx to handle file and folder selection with fileMapper() and persistSelectedFilesOnConnection().
    • Remove UI rendering in GoogleDrivePicker.tsx, returning null instead.
  • Dependencies:
    • Update @opensdks/fetch-links to ^0.0.22 in package.json files for web, connector-plaid, loopback-link, cdk, vdk, and api.
    • Update @opensdks/sdk-openint to ^0.1.15 in file-picker/package.json.
  • Misc:
    • Remove calendar.tsx from file-picker/src/components/ui/.

This description was created by Ellipsis for 6d4c770. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openint ❌ Failed (Inspect) Jan 27, 2025 10:42pm

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c0b14e6 in 2 minutes and 3 seconds

More details
  • Looked at 323 lines of code in 14 files
  • Skipped 2 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. apps/web/package.json:29
  • Draft comment:
    Dependency version updated from ^0.0.19 to ^0.0.22. Ensure compatibility with the rest of the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The update to the @opensdks/fetch-links dependency version is consistent across multiple package.json files. This is a straightforward version bump, and there are no apparent issues with this change.
2. connectors/connector-google/def.ts:10
  • Draft comment:
    Added client_id to zSettings. Ensure this is used consistently across the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The addition of client_id to the zSettings schema is consistent with the changes in the server.ts file where client_id is used. This change seems intentional and necessary for the functionality.
3. connectors/connector-google/server.ts:169
  • Draft comment:
    Added client_id to settings in postConnect. Ensure this is consistent with schema changes.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The client_id is being added to the settings object in the postConnect function. This aligns with the schema changes in def.ts. The change seems intentional and necessary for the functionality.
4. kits/file-picker/src/pickers/google/GoogleDrivePicker.tsx:109
  • Draft comment:
    UI rendering removed, returning null. Verify this aligns with intended functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of UI rendering in GoogleDrivePicker and returning null is a significant change. This should be verified to ensure it aligns with the intended functionality of the component.

Workflow ID: wflow_YYWDbOPnPpvArcXi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6d4c770 in 11 seconds

More details
  • Looked at 69 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_3BMic0i3F7c8i1cd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@pellicceama pellicceama merged commit d64bce6 into main Jan 27, 2025
3 of 4 checks passed
@pellicceama pellicceama deleted the drive-filepicker branch January 27, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant