Align terminology in diagram with section header #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are 10 places that the word "evaluate" (including "reevaluate") occurs in the specification, including another occurrence in the same figure. I'm not necessarily opposed to the proposed change, but if we're going to do it for this one occurrence, we should consider what wording we want to use in the other occurrences as well, so that we're being consistent overall. |
|
Agree -- evaluate, resolve, and validate would all be good to define or narrow down if there's redundancy |
|
@rohe and I looked at this today. We agree with changing "evalute" in the context of Trust Chains to "validate". We do not want to change all the other uses of "evaluate". |
|
The asciiflow.com source in the comment above should be edited as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Figure 47 says "Evaluate the Trust Chain", I think it's referring to the process described in https://openid.net/specs/openid-federation-1_0.html#section-10.2 which is called "Validating a Trust Chain". If so, it would be good to use the same wording ("Validate" rather than "Evaluate") in the Figure.