Skip to content

Main UI: Visualize semantic model tree in item details screen #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Jun 12, 2025

Closes #3217

This is not ready for merging as it heavily relies on #3165, #3178 and #3223. All the code from these PR's is included in this one, so it is fully functional. It should be rebased once the other PR's have been reviewed.

This PR extends the item details screen to show part of the model the item is in, from the top, down to all its children. The tree is opened up to the level of the item. Clicking on a level in the tree, will take you to the related item.

With this PR, the terminology discussion from #3211 becomes less critical as the terminology is replaced by a graphical representation of the model with all information in it.

Below is how it looks like.

Note the Parent Group and Child Group sections will contain all semantic and non-semantic direct parent and child groups.

image

A concern may be this is introducing a load of the full model for each item. The REST API call only retrieves static data, therefore I believe it is cached and should not continuously pass the full payload over the network. In my tests with over 1000 items, I didn't see a strong negative performance impact, but it may depend on the system. An improvement could be to move the filtering to OH core with an extra REST parameter. However, this will also make caching less relevant.

mherwege added 15 commits May 1, 2025 18:11
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
@mherwege mherwege marked this pull request as draft June 12, 2025 13:00
Copy link

relativeci bot commented Jun 12, 2025

#3198 Bundle Size — 11.31MiB (+0.4%).

d6a06e6(current) vs c12c18c main#3179(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 7 changes Regression 2 regressions
                 Current
#3198
     Baseline
#3179
Regression  Initial JS 2.01MiB(+0.03%) 2.01MiB
No change  Initial CSS 577.53KiB 577.53KiB
Change  Cache Invalidation 21.12% 18.33%
Change  Chunks 253(+0.8%) 251
Change  Assets 276(+0.73%) 274
Change  Modules 3017(+0.84%) 2992
Regression  Duplicate Modules 157(+6.08%) 148
Change  Duplicate Code 1.73%(+2.37%) 1.69%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#3198
     Baseline
#3179
Regression  JS 9.51MiB (+0.43%) 9.47MiB
Regression  CSS 874.6KiB (+0.52%) 870.07KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:sub_modelProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the full semantic hierarchy on Item's page
1 participant