Skip to content

Fix regressions caused by wrong YAML library usage #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix regressions caused by wrong YAML library usage #2300

merged 2 commits into from
Feb 2, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Feb 2, 2024 •
edited
Loading

Regression from #2267.

In #2267 the YAML library was upgraded to a new version, but the usage of the library was not adjusted to breaking changes.
This PR fixes all issues discouvered in the browser console.

@florian-h05
Fix TypeError when setting YAML lineLength
15899cf 
Regression from openhab#2267.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner February 2, 2024 20:50
@florian-h05 florian-h05 changed the title Fix TypeError when setting YAML lineLength Fix blocks-edit & widget-edit broken due to wrong YAML library usage Feb 2, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 2, 2024 •
edited
Loading

Job #1394: Bundle Size — 11MiB (~+0.01%).

dcd03b8(current) vs 1c03c60 main#1391(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1394		      Baseline
Job #1391
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.72% 95.87%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1394		      Baseline
Job #1391
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1394 report View florian-h05:fix-yaml-linelength branch activity View project dashboard

@florian-h05 florian-h05 changed the title Fix blocks-edit & widget-edit broken due to wrong YAML library usage Fix regressions caused by wrong YAML library usage Feb 2, 2024
@florian-h05
Copy link
Contributor Author

FYI @GiviMAD

@florian-h05 florian-h05 merged commit 287009e into openhab:main Feb 2, 2024
@florian-h05 florian-h05 deleted the fix-yaml-linelength branch February 2, 2024 21:26
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Feb 2, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05