Skip to content

allow building of most projects on M1 processors #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Nov 28, 2021

This mainly upgrades NodeJS from 12.16.1 to 16.13.0. The only bundle that still can't be built is HaBOT because there are too many "old" dependencies that I am not able to update due to lack of knowledge.

Related to #1165

Signed-off-by: Jan N. Klug [email protected]

This mainly upgrades NodeJS from 12.16.1 to 16.13.0. The only bundle that still can't be built is HaBOT because there are too many "old" dependencies that I am not able to update due to lack of knowledge.

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K requested a review from a team as a code owner November 28, 2021 10:34
@ghys
Copy link
Member

ghys commented Nov 28, 2021

Thanks but it would be better to have a consistent version of node/npm across all bundles (HABPanel & HABot included) to avoid downloading and caching multiple versions. It was a mess before and #202 made it a little better.

@J-N-K
Copy link
Member Author

J-N-K commented Nov 28, 2021

I'm out then. I have no idea how to get that "quasar-cli" package updated. The last update is two years old and doesn't run with modern node as far as I found out (due to a dependency to fsevents/1.x which doesn't run on node 13+).

@J-N-K J-N-K closed this Nov 28, 2021
@ghys
Copy link
Member

ghys commented Apr 13, 2022

@J-N-K since you figured out the issues w/ basic UI already can you reopen this one, as you were the first to work on this? It turns out HABot does build on Linux (just not on macOS, which isn't critical imho).
Also while you're at it can you please set:

          <nodeVersion>v16.14.2</nodeVersion>
          <npmVersion>8.6.0</npmVersion>

If it builds and has no regressions then it's fine by me (and I'll close #1352).

@J-N-K
Copy link
Member Author

J-N-K commented Apr 13, 2022

Looks like I'm not allowed to re-open a PR.

@ghys
Copy link
Member

ghys commented Apr 13, 2022

Ok, me neither. There's a tooltip when I hover the button "the branch was force-pushed or recreated".
I'll incorporate your changes in #1352 and credit you with an Also-by sign-off then.

(edit: never mind I'll use your new PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants