Skip to content

Fix/hero floating width #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 2, 2025
Merged

Fix/hero floating width #1375

merged 9 commits into from
Jun 2, 2025

Conversation

adriangohjw
Copy link
Member

Problem

Floating variance is not full width if the text is too short

Ref: https://opengovproducts.slack.com/archives/C06R4DX966P/p1748325229517369

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • adding full width but capped with calculated max-width

Before & After Screenshots

BEFORE:

image

AFTER:

image

Tests

  • refer to storybook

@adriangohjw adriangohjw self-assigned this May 27, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner May 27, 2025 22:01
@adriangohjw adriangohjw added the bug Something isn't working label May 27, 2025
adriangohjw
adriangohjw commented May 27, 2025
View reviewed changes
apps/studio/prisma/generated/generatedEnums.ts Outdated
Copy link
Member Author

@adriangohjw adriangohjw May 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated lint and fix

adriangohjw
adriangohjw commented May 27, 2025
View reviewed changes
adriangohjw
adriangohjw commented May 27, 2025
View reviewed changes
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented May 27, 2025 •
edited
Loading

Datadog Report

Branch report: fix/hero-floating-width
Commit report: 7634eae
Test service: isomer-studio

✅ 0 Failed, 566 Passed, 46 Skipped, 1m 48.75s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-11%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • vitest run --coverage 9.69% (-11%) - Details

seaerchin
seaerchin approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor question; tested with single word title + description; the hero floating box still looked good

@adriangohjw adriangohjw requested a review from sehyunidaaa May 29, 2025 11:00
@adriangohjw
Copy link
Member Author

@sehyunidaaa i have added another example to show how it looks like on homepage!

@adriangohjw adriangohjw merged commit 3bfce12 into main Jun 2, 2025
20 checks passed
@adriangohjw adriangohjw deleted the fix/hero-floating-width branch June 2, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

@sehyunidaaa sehyunidaaa sehyunidaaa approved these changes

Assignees

@adriangohjw adriangohjw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriangohjw @seaerchin @sehyunidaaa