Skip to content

Fix godmode publishall #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Fix godmode publishall #1364

merged 2 commits into from
May 27, 2025

Conversation

adriangohjw
Copy link
Member

Problem

app crashes due to spike in connection pool opening and exceeding Prisma's default connection pool of 10

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Improvements:

  • do a loop instead of Promise.all
  • process these in the background insstead of holding onto the thread -> also give more immediate feedback to the user

@adriangohjw adriangohjw self-assigned this May 26, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner May 26, 2025 15:34
@adriangohjw adriangohjw added the bug Something isn't working label May 26, 2025
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented May 26, 2025

Datadog Report

Branch report: fix-godmode-publishall
Commit report: 5d3a63d
Test service: isomer-studio

✅ 0 Failed, 550 Passed, 46 Skipped, 1m 30.11s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit a83357d into main May 27, 2025
17 checks passed
@adriangohjw adriangohjw deleted the fix-godmode-publishall branch May 27, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants