isom-1852 collection widget on homepage latest articles #1250
+1,759
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for clarity and consistency
…INTERNAL_HREF_PATTERN for internal link validation
…ing icon in TYPE_TO_ICON mapping
Datadog ReportBranch report: ✅ 0 Failed, 582 Passed, 46 Skipped, 1m 45.58s Total Time |
…nents package and update imports
…constants for default sort by and direction
…ages and add lazy loading support
…S constant for number of pages
…ngohjw/isom-1852-collection-widget-on-homepage-latest-articles
dcshzj
approved these changes
May 6, 2025
...omponents/src/templates/next/components/complex/CollectionBlock/utils/getCollectionParent.ts
Outdated
Show resolved
Hide resolved
packages/components/src/templates/next/components/complex/CollectionBlock/CollectionBlock.tsx
Outdated
Show resolved
Hide resolved
…ngohjw/isom-1852-collection-widget-on-homepage-latest-articles
…ap array for improved performance
…ngohjw/isom-1852-collection-widget-on-homepage-latest-articles
…omepage-latest-articles
…omepage-latest-articles
…ngohjw/isom-1852-collection-widget-on-homepage-latest-articles
* enhance getLocalisedSitemap to get nested children folders and collections * Update sitemap layout handling to differentiate between Collection and Content types * add image * add overwriteCollectionChildrenForCollectionBlock to modify collection block children * Enhance sitemap generation by adding content selection for resources and updating getLocalisedSitemap to include index pages and nested children * add check fo rtype * update mocks to be more robust + fix indexpage permalink * add tests * remove only * add checks for image * add beforeeach * Enhance resource service tests by adding collection index page scenarios and refining existing test descriptions. Update setupCollection to accept state parameter. * remove "only" * fix * update query * remove * enhance getLocalisedSitemap to include nested resources and update query logic
adriangohjw
deleted the
adriangohjw/isom-1852-collection-widget-on-homepage-latest-articles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes https://linear.app/ogp/issue/ISOM-1852/collection-widget-on-homepage-latest-articles
Solution
Breaking Changes
This has breaking change as studio will try to render the component in preview and crash as there's no sitemap. There's an attempt to fix it in #1277
Features:
Improvements:
Tests