Skip to content

Bruceyan/issue#1106 #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

yanrongzhen
Copy link
Member

@yanrongzhen yanrongzhen commented Mar 16, 2023

Fixes #1106

  • 适配SpringBoot 1.x版本对于web容器的修改.
  • 重构adpater-web模块, 抽象公共部分沉到adapter-web. 由1x-starter和adapter-web各自实现自身版本的web容器相关逻辑
  • 修复当web配置中缺少某几个字段时, 修改线程池配置出现NPE的情况.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a3724dd) 28.01% compared to head (04dd381) 28.01%.

❗ Current head 04dd381 differs from pull request most recent head 19a6a1f. Consider uploading reports for the commit 19a6a1f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1125   +/-   ##
==========================================
  Coverage      28.01%   28.01%           
  Complexity       717      717           
==========================================
  Files            258      258           
  Lines           5864     5864           
  Branches         536      536           
==========================================
  Hits            1643     1643           
  Misses          4063     4063           
  Partials         158      158           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@magestacks
Copy link
Member

@yanrongzhen 可以帮忙创建个 Issue 说明下本次开发的背景和目标,后续我创建新版本发布可以总结说明

@yanrongzhen
Copy link
Member Author

@magestacks 收到

@pizihao
Copy link
Collaborator

pizihao commented Mar 16, 2023

老哥,类和方法上的注释补一下,补完了回我一下,我再合代码

@yanrongzhen
Copy link
Member Author

@pizihao 我这边补好了, 帮忙看看还有没有漏掉的

@pizihao pizihao merged commit 9f94d9d into opengoofy:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

springBoot 1.5.x适配Web容器线程池调整
3 participants