Skip to content

feat: Change model prediction output from tuple to dict #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

streino
Copy link
Contributor

@streino streino commented Jul 5, 2022

Fixes #84

Model prediction output:

  • Before PR: (scores, labels) tuple
  • After PR: {'labels': labels, 'scores': scores} dict

streino added 9 commits June 1, 2022 13:04
Replaces OutputMapperLayer with a custom serving function.

This means we don't need to save two models (training/serving)
anymore, as the (ex training) model will do the "output mapping"
through the custom serving function.

With this approach, we could even have multiple serving functions with
different output mapping strategies.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@streino streino requested a review from alexgarel July 5, 2022 13:56
@streino
Copy link
Contributor Author

streino commented Jul 5, 2022

Leaving this here as draft for now, until:

Base automatically changed from refactor-saved-model to master July 6, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant