Skip to content

Ajoute l'aide permis de conduire de region Nouvelle Aquitaine #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

Allan-CodeWorks
Copy link
Contributor

@Allan-CodeWorks Allan-CodeWorks commented Sep 11, 2023

[6.3.0] - 2023-09-11

Added

  • Ajoute la variable nouvelle_aquitaine_aide_permis

Changed

  • Créé un dossier pour les pour les paramètres de la carte solidaire de la région Nouvelle Aquitaine

Removed

  • Retire la compatibilité avec openfisca-france v153.0.1 et inférieur

@Allan-CodeWorks Allan-CodeWorks self-assigned this Sep 11, 2023
@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch from 6dacefd to 7b3cd29 Compare September 11, 2023 08:42
@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch 2 times, most recently from a1052e6 to b1567e8 Compare September 11, 2023 11:35
@Allan-CodeWorks Allan-CodeWorks requested a review from a team September 11, 2023 11:43
@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch from b1567e8 to 2200609 Compare September 11, 2023 12:02
Copy link
Contributor

@Shamzic Shamzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une suggestion pour améliorer la lisibilité de la méthode def formula de l'aide au permis de la nouvelle aquitaine, spliter en petites méthodes pour avoir une méthode formula plus petite afin de voir clairement les calculs requis

@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch from 61db4e7 to 209cf44 Compare September 13, 2023 15:17
Copy link
Contributor

@baptou12 baptou12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai des questions sur eligibilite_profile si on peut faire ça en synchro

@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch from 209cf44 to e7a3859 Compare September 15, 2023 09:19
@Allan-CodeWorks
Copy link
Contributor Author

Labels + documentation sur la modélisation ajoutées.

@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch 2 times, most recently from fe828af to feb3287 Compare September 18, 2023 10:04
@Allan-CodeWorks Allan-CodeWorks force-pushed the aide_permis_region_nouvelle-aquitaine branch from feb3287 to b70d2c9 Compare September 18, 2023 11:23
@baptou12 baptou12 dismissed their stale review September 18, 2023 13:12

Après discussion ce n'est pas bloquant

@Allan-CodeWorks Allan-CodeWorks merged commit 0ece0c9 into master Sep 18, 2023
@Allan-CodeWorks Allan-CodeWorks deleted the aide_permis_region_nouvelle-aquitaine branch September 18, 2023 13:14
@guillett guillett added this to the BC 1406243900 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants