Skip to content

fix: Fix for the Paragon modal shadow, which prevents clicking on an elements on the grading page #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Lunyachek
Copy link
Contributor

Minor issue was found on the "View all responses" modal window. This modal window is based on the Paragon Modal component, which has top and bottom shadows to indicate that there is some content at the top or bottom. These shadows are made with :before and :after pseudo-elements and should stick to the top and bottom. Example below:

2024-09-25.15.46.53.mov

But in the Grading modal window, the bottom shadow "has a life of its own" and takes various positions on the page, sometimes covering different elements depending on the scroll position or browser window size. Sometimes it's impossible to click the submit button or select a grade.

In the example below, I colored the bottom pseudo-element :after in red for clarity, to demonstrate that it’s not sticking to the bottom of the page.

2024-09-25.16.00.24.mov

To fix this bug, it is necessary to remove the height: 100% property set for .review-modal-body > div.pgn__modal-body-content. This property was added in this commit: dd880d4

After I removed height: 100%, I didn’t notice any issues with other elements on the page. Perhaps @leangseu-edx could point out if there’s something I might have missed?

2024-09-25.16.03.54.mov

@openedx-webhooks
Copy link

openedx-webhooks commented Sep 25, 2024

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @codewithemad.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb06133) to head (8154849).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1085      1085           
  Branches       166       165    -1     
=========================================
  Hits          1085      1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 27, 2024
@mphilbrick211 mphilbrick211 removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Dec 9, 2024
@CodeWithEmad
Copy link
Member

@Lunyachek can you kindly resolve the conflict?

@CodeWithEmad CodeWithEmad added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 18, 2024
@Lunyachek
Copy link
Contributor Author

@Lunyachek can you kindly resolve the conflict?

Done!

@CodeWithEmad
Copy link
Member

@Lunyachek I still can't merge this due to conflict

@ihor-romaniuk
Copy link

Hello @CodeWithEmad
The conflicts have been resolved and it seems there is nothing blocking us from merging.

@CodeWithEmad
Copy link
Member

Still can't merge the branch, @ihor-romaniuk

image

@ihor-romaniuk
Copy link

@CodeWithEmad I can't see any problems with this PR.
image

@Lunyachek probably, you can check it on your side with the PR owner permissions?

@Lunyachek
Copy link
Contributor Author

Lunyachek commented Feb 3, 2025

I also can't see any problems

Снимок экрана 2025-02-04 в 00 34 26

@CodeWithEmad
Copy link
Member

Screenshot_2025-02-14-01-16-17-652_com.github.android.jpg

Weirdly enough, I see the rebase button, but I can't rebase even from the GitHub app.

@Lunyachek Lunyachek force-pushed the lunyahcek/fix/paragon-modal-shadow-prevents-submit-click-master branch from ae302b4 to 8154849 Compare February 19, 2025 14:57
@Lunyachek
Copy link
Contributor Author

I made rebase locally. @CodeWithEmad please check now

@CodeWithEmad CodeWithEmad merged commit 0843057 into openedx:master Feb 19, 2025
6 checks passed
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 19, 2025
@Lunyachek Lunyachek deleted the lunyahcek/fix/paragon-modal-shadow-prevents-submit-click-master branch February 19, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants