-
Notifications
You must be signed in to change notification settings - Fork 50
fix: Fix for the Paragon modal shadow, which prevents clicking on an elements on the grading page #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1085 1085
Branches 166 165 -1
=========================================
Hits 1085 1085 ☔ View full report in Codecov by Sentry. |
@Lunyachek can you kindly resolve the conflict? |
Done! |
@Lunyachek I still can't merge this due to conflict |
Hello @CodeWithEmad |
Still can't merge the branch, @ihor-romaniuk |
@CodeWithEmad I can't see any problems with this PR. @Lunyachek probably, you can check it on your side with the PR owner permissions? |
…element on the grading page
ae302b4
to
8154849
Compare
I made rebase locally. @CodeWithEmad please check now |
Minor issue was found on the "View all responses" modal window. This modal window is based on the Paragon Modal component, which has top and bottom shadows to indicate that there is some content at the top or bottom. These shadows are made with
:before
and:after
pseudo-elements and should stick to the top and bottom. Example below:2024-09-25.15.46.53.mov
But in the Grading modal window, the bottom shadow "has a life of its own" and takes various positions on the page, sometimes covering different elements depending on the scroll position or browser window size. Sometimes it's impossible to click the submit button or select a grade.
In the example below, I colored the bottom pseudo-element
:after
in red for clarity, to demonstrate that it’s not sticking to the bottom of the page.2024-09-25.16.00.24.mov
To fix this bug, it is necessary to remove the
height: 100%
property set for.review-modal-body > div.pgn__modal-body-content
. This property was added in this commit: dd880d4After I removed
height: 100%
, I didn’t notice any issues with other elements on the page. Perhaps @leangseu-edx could point out if there’s something I might have missed?2024-09-25.16.03.54.mov