Skip to content

feat: import FooterSlot from component package instead of slot package #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Apr 18, 2025

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (cb1de82) to head (a1f5e49).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         152      152           
  Lines        1327     1327           
  Branches      219      220    +1     
=======================================
  Hits         1293     1293           
  Misses         33       33           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril force-pushed the footerslot-from-component branch from b64d57b to de72055 Compare April 21, 2025 18:16
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review April 21, 2025 20:03
@brian-smith-tcril brian-smith-tcril requested a review from a team as a code owner April 21, 2025 20:03
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked until edx/frontend-component-footer-edx#476 is resolved.

@deborahgu deborahgu moved this to Blocked in Aperture-Maintained Apr 22, 2025
@brian-smith-tcril
Copy link
Contributor Author

@deborahgu can someone address edx/frontend-component-footer-edx#476 ASAP? The plan is to land these for Teak and the cut is on Thursday.

@deborahgu deborahgu added blocked by other work PR cannot be finished until other work is complete needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Apr 22, 2025
@e0d
Copy link
Contributor

e0d commented Apr 22, 2025

@deborahgu What's the time frame for landing the workaround? We think this is a simple fix, includes expand contract for y'all, and we need to land this for the Teak cut-off, Thursday.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks good. 👍🏼

@deborahgu
Copy link
Member

I'm investigating and will note back as soon as I hear anything. No change is that simple when it's an upstream component and the change has to propagate through multiple repos owned by multiple stakeholders. 😉

@brian-smith-tcril
Copy link
Contributor Author

@deborahgu I do want to emphasize that the change I suggested in edx/frontend-component-footer-edx#476 is non-breaking. Footer is still exported as Footer, StudioFooter is still exported as StudioFooter, they are just also exported under the aliases FooterSlot and StudioFooterSlot.

@deborahgu
Copy link
Member

deborahgu commented Apr 22, 2025

Thanks, we'll look at the change. Since we learned about the breaking changes after the end of day Thursday, and it's been a long weekend, this is giving us fewer than three days in our normal workflow to see what we need to change on our end. We are treating this as a top priority, but please understand that this is an extraordinary ask and we're not going to be able to validate this in a five minute turnaround. We still intend to land it before teak.

@e0d
Copy link
Contributor

e0d commented Apr 22, 2025

@deborahgu We really appreciate you prioritizing it. It's incredibly helpful. We -- @brian-smith-tcril mostly -- have tried to make it a seamless change with a shim to provide backward compatibility for y'all.

A little further along, we should have a retro. There are some key areas to discuss in the process I think.

@brian-smith-tcril brian-smith-tcril force-pushed the footerslot-from-component branch from de72055 to a1f5e49 Compare April 24, 2025 16:17
@brian-smith-tcril brian-smith-tcril merged commit fe386e3 into openedx:master Apr 24, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Blocked to Done in Aperture-Maintained Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete create-sandbox open-craft-grove should create a sandbox environment from this PR needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants