feat: import FooterSlot from component package instead of slot package
#765
+14
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
added
the
create-sandbox
brian-smith-tcril
force-pushed
the
footerslot-from-component
branch
2 times, most recently
from
2ead8da to
eecb924
Compare
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 161 161
Lines 3402 3402
Branches 919 923 +4
=======================================
Hits 3169 3169
Misses 215 215
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment successful 🚀 |
arbrandes
approved these changes
Apr 22, 2025
| @@ -27,7 +27,7 @@ import { selectPostEditorVisible } from '../posts/data/selectors'; | |||
| import { isCourseStatusValid } from '../utils'; | |||
| import useFeedbackWrapper from './FeedbackWrapper'; | |||
|
|
|||
| const FooterSlot = lazy(() => import('@openedx/frontend-slot-footer')); | |||
| const FooterSlot = lazy(() => import('@edx/frontend-component-footer').then(module => ({ default: module.FooterSlot }))); | |||
There was a problem hiding this comment.
Just checking: will this work for importing { FooterSlot } as a named export? I assume this is what the promise handling is for.
There was a problem hiding this comment.
Yes. The promise gets us the entire thing (module), and then we can grab FooterSlot from that
I followed the pattern from here https://stackoverflow.com/a/66289130
brian-smith-tcril
force-pushed
the
footerslot-from-component
branch
from
eecb924 to
9f878c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.pr-765-2977b1.sandboxes.opencraft.hosting/discussions/course-v1:demo+Course+1/posts