Skip to content

feat: import FooterSlot from component package instead of slot package #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

feat: import FooterSlot from component package instead of slot package #226

merged 1 commit into from
Apr 24, 2025
+269 −215

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Apr 18, 2025 •
edited
Loading

@brian-smith-tcril brian-smith-tcril mentioned this pull request Apr 18, 2025
Closed
11 tasks
@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 18, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (1673833) to head (68da7bb).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          47       47           
  Lines         695      695           
  Branches      135      135           
=======================================
  Hits          584      584           
  Misses        111      111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review April 21, 2025 18:05
arbrandes
arbrandes approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brian-smith-tcril brian-smith-tcril force-pushed the footerslot-from-component branch from 8c062ff to 68da7bb Compare April 24, 2025 16:01
@brian-smith-tcril brian-smith-tcril merged commit 0c1eb6c into openedx:master Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-smith-tcril @open-craft-grove @arbrandes