Skip to content

fix: prevent full iframe reload after xblock edition #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bra-i-am
Copy link
Contributor

@bra-i-am bra-i-am commented Jul 4, 2025

Description

This PR addresses an issue that causes a full iframe reload after saving edited xblock data. To prevent the page reload, these changes remove the entire iframe reload, which was part of a previous implementation to display the Publish button after editing an xblock. However, this PR uses a different approach to achieve that.

Supporting information

This PR fixes point 1 in the issue #1893

Testing instructions

Before After
Screencast from 04-07-25 12:01:53.webm Screencast from 04-07-25 11:59:48.webm

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 4, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.17%. Comparing base (ad62519) to head (7cc6c1f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/course-unit/data/slice.js 0.00% 3 Missing ⚠️
src/course-unit/hooks.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
- Coverage   94.17%   94.17%   -0.01%     
==========================================
  Files        1167     1167              
  Lines       24678    24677       -1     
  Branches     5271     5272       +1     
==========================================
- Hits        23241    23239       -2     
- Misses       1369     1370       +1     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bra-i-am bra-i-am force-pushed the bc/authoring#1893 branch from 739668d to 7cc6c1f Compare July 4, 2025 20:07
@bra-i-am bra-i-am changed the title Bc/authoring#1893 fix: prevent full iframe reload after xblock edit by refactoring publish state handling Jul 4, 2025
@bra-i-am bra-i-am changed the title fix: prevent full iframe reload after xblock edit by refactoring publish state handling fix: prevent full iframe reload after xblock edition Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants