-
Notifications
You must be signed in to change notification settings - Fork 135
fix: prevent full iframe reload after xblock edition #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2257 +/- ##
==========================================
- Coverage 94.17% 94.17% -0.01%
==========================================
Files 1167 1167
Lines 24678 24677 -1
Branches 5271 5272 +1
==========================================
- Hits 23241 23239 -2
- Misses 1369 1370 +1
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
739668d
to
7cc6c1f
Compare
Description
This PR addresses an issue that causes a full iframe reload after saving edited xblock data. To prevent the page reload, these changes remove the entire iframe reload, which was part of a previous implementation to display the
Publish
button after editing an xblock. However, this PR uses a different approach to achieve that.Supporting information
This PR fixes point 1 in the issue #1893
Testing instructions