-
Notifications
You must be signed in to change notification settings - Fork 135
Convert the "Taxonomy" app to 100% TypeScript #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Convert all JSX files in the taxonomy module to TypeScript: - Replace PropTypes with TypeScript interfaces - Replace defaultProps with ES6 default parameters - Add proper type annotations for variables, parameters, and return values 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Convert mock files in __mocks__ directory to TypeScript - Convert api.js in manage-orgs/data directory to TypeScript - Fix type issues to pass TypeScript type checking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
- Remove unused imports - Fix line length issues - Add missing newlines at end of files - Fix other linting issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Use inline values in mock implementations instead of referencing variables - Fixes "Cannot access variable before initialization" error 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 93.95% 93.97% +0.01%
==========================================
Files 1154 1155 +1
Lines 24116 24204 +88
Branches 5219 5232 +13
==========================================
+ Hits 22659 22746 +87
+ Misses 1389 1381 -8
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @bradenmacdonald I just wanted to make sure that you get a chance to review the brand new policy on AI code as you move forward with this: https://openedx.atlassian.net/wiki/spaces/COMM/pages/5022416899/Open+edX+Policy+for+Generative+AI+Tools |
Description
This is a PR generated 95% by Claude Code to convert the
taxonomy
app in frontend-app-authoring to TypeScript.Supporting information
Prompts:
(It created new .tsx files, but didn't delete the old .jsx)
(Then I noticed it hadn't converted some .js files)
(this made the AI realize it had missed a few files, and it then converted them and committed changes all on its own. In retrospect, I did say to only convert '.jsx' not '.js and .jsx' so that was an incomplete instruction.)
( I pushed, and GitHub CI showed a test failure)
(It made a fix that I didn't like)
Testing instructions
Manually verify the taxonomy UI is functional and unchanged.
Other information
Inspired by @regisb - https://discuss.openedx.org/t/i-just-spent-13-5-for-type-annotations-on-2-8k-lines-of-code-and-i-think-you-should-too/15977