Skip to content

feat: [FC-86] implement multivalue faceted search using Meilisearch #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Serj-N
Copy link

@Serj-N Serj-N commented Jul 9, 2025

Add logic to MeilisearchEngine to support filtering courses by multiple options within a single facet category.

  • The changes are made in the meilisearch module, with one exception being api.course_discovery_search to make integration testing possible at this stage of development.
  • Added unit tests and integration tests.
  • A make command is added to make it easy to run tests in a docker container.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 9, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 9, 2025

Thanks for the pull request, @Serj-N!

This repository is currently maintained by @Ali-Salman29.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jul 9, 2025
@Serj-N Serj-N changed the title feat: [AXM-2518] implement multivalue faceted search using Meilisearch feat: [FC-86] implement multivalue faceted search using Meilisearch Jul 9, 2025
@Serj-N Serj-N marked this pull request as ready for review July 10, 2025 10:33
@mphilbrick211 mphilbrick211 added FC Relates to an Axim Funded Contribution project needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Jul 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Jul 15, 2025
@e0d
Copy link

e0d commented Jul 16, 2025

@Serj-N
I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it.

@Serj-N
Copy link
Author

Serj-N commented Jul 16, 2025

@e0d Hello and thank you! Invitation accepted

@e0d
Copy link

e0d commented Jul 16, 2025

@Serj-N It looks like there are some failed checks, please have a look.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 16, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants