Skip to content

fix: fixed styles for legacy xblock's editor #36923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bydawen
Copy link
Contributor

@bydawen bydawen commented Jun 17, 2025

There is a problem with a styles for the legacy xblock's editor in CMS:
openedx/frontend-app-authoring#1904

Currently, styles are used there that correspond to legacy theme, not to paragon design system.

Main goal of this PR is tweak current styles for greater consistency with paragon, and fix some style bugs (input and textarea styles, button colors, border colors, hover and focus styles etc.)

Some of fixed xblock's editors for example:
Screenshot 2025-06-17 at 12 36 41
Screenshot 2025-06-17 at 12 37 14
Screenshot 2025-06-17 at 12 38 03
Screenshot 2025-06-17 at 13 12 25
Screenshot 2025-06-17 at 13 13 11
Screenshot 2025-06-17 at 13 43 19

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 17, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 17, 2025

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bydawen bydawen force-pushed the fix/xblocks-editor-styles branch from 39796b8 to 0bf6bfb Compare June 17, 2025 10:48
@bydawen bydawen marked this pull request as ready for review June 19, 2025 07:55
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 20, 2025
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jun 20, 2025
@@ -305,12 +305,12 @@ $state-danger-border: darken($state-danger-bg, 5%) !default;

$text-dark-black-blue: #2c3e50;

$primary: #0a3055 !default;
$primary-base: #0a3055 !default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] Why do we need to change variable names?

@@ -3,7 +3,7 @@
@import 'neat/neat'; // lib - Neat
@import 'vendor/bi-app/bi-app-ltr'; // set the layout for left to right languages
@import 'build-v1'; // shared app style assets/rendering
@import 'cms/theme/variables-v1';
@import './partials/cms/theme/_variables-v1.scss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] I'm not sure that we need to change this import. What is the reason of this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants