fix: update container key field usage #36679
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cms/djangoapps/contentstore/tasks.py
Outdated
| @@ -1507,6 +1507,6 @@ def handle_unlink_upstream_block(upstream_usage_key_string: str) -> None: | |||
| ): | |||
| make_copied_tags_editable(str(link.downstream_usage_key)) | |||
| for link in ContainerLink.objects.filter( | |||
| upstream_usage_key=upstream_usage_key, | |||
| upstream_container_key=upstream_usage_key, | |||
There was a problem hiding this comment.
@navinkarkera Sorry, could I get some more context for this change? What's the issue it fixes?
There was a problem hiding this comment.
@pomegranited Updated the description, the field was renamed to upstream_container_key.
There was a problem hiding this comment.
Sorry @navinkarkera , I still don't understand.. Upstream container keys aren't UsageKeys, so won't we get a InvalidKeyError above if this function is called with a container key?
There was a problem hiding this comment.
@pomegranited You are completely right! Moved this part to its own task when containers are deleted.
navinkarkera
force-pushed
the
navin/minor-fix
branch
from
44394cd to
b7793c4
Compare
There was a problem hiding this comment.
👍 Thanks for this fix @navinkarkera :)
- I tested this on my tutor dev stack with latest master Authoring MFE:
- created a new library unit, added tags, and published.
- added the library unit to a course -- tags were copied over and marked read-only
- deleted the library unit
- verified via shell that the copied tags are now editable
- I read through the code
-
I checked for accessibility issues by using my keyboard to navigateN/A - Includes documentation
-
User-facing strings are extracted for translationN/A
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
A minor fix that updates field name usage of
ContainerLinkmodel in tasks.The
upstream_usage_keyfield was renamed toupstream_container_keyforContainerLinkmodel.Deadline
ASAP.