feat: export ora2 summary to DRF #36555
Open
+27
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awais786 PR is ready for review. |
awais786
reviewed
Apr 21, 2025
| report_type = _('ORA summary') | ||
| task_api.submit_export_ora2_summary(request, course_key) | ||
| success_status = SUCCESS_MESSAGE_TEMPLATE.format(report_type=report_type) | ||
| authentication_classes = ( |
There was a problem hiding this comment.
You can remove this. It will use default DRF authentication classes.
Talha-Rizwan
force-pushed
the
export_ora2_summary-to-drf
branch
from
cb4e2cd to
a1edf7a
Compare
awais786
approved these changes
Apr 29, 2025
Talha-Rizwan
force-pushed
the
export_ora2_summary-to-drf
branch
from
a1edf7a to
1c4ba4f
Compare
|
@feanil please review. |
|
@awais786 you've done enough of these DRF changes now that if something looks good to you, feel free to approve and merge it. I don't need to serve as a blocking review if you think it's good to go unless you have specific concerns. I don't need to review everything, just tag me on ones that you think might be risky or where you have less confidence. |
|
@feanil got it, I will merge this and others after review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35353 issue for tracking
Description
Converts the function-based export_ora2_summary view to a DRF class-based view
This change maintains all existing functionality while providing a more standardized API structure.
Key changes:
To Test the api, try POST request on this url
expected response:
status: "The ORA summary report is being created. To view the status of the report, see Pending Tasks below."a celery task will be triggered and a csv file will be generated.
verify via instructor dashbaord
go to this page
click on the button "Generate ORA Summart Report"