Skip to content

feanil/fix docs build #36259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged

feanil/fix docs build #36259

merged 3 commits into from
Feb 19, 2025

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Feb 14, 2025

  • build: Add more apps to the set of installed apps.
  • build: We don't need to override this setting.
  • docs: Update the Open API docs.

These app models get pulled in when trying to build the OpenAPI docs so
we need their relevant apps installed into the environment used to
generate the docs.
docs/conf.py Outdated
@@ -112,7 +112,7 @@
# You can specify multiple suffix as a list of string:
#
# source_suffix = ['.rst', '.md']
source_suffix = '.rst'
# source_suffix = '.rst'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just get deleted?

@bmtcril
Copy link
Contributor

bmtcril commented Feb 14, 2025

Are the Open API docs generated somehow or are these manual edits?

The format of the `source_suffix` setting has change but the default is
fine for us so we don't need to override this.
@feanil feanil force-pushed the feanil/fix_docs_build branch from f6572bd to b079d4c Compare February 14, 2025 20:51
@feanil
Copy link
Contributor Author

feanil commented Feb 14, 2025

The API docs are generated as a part of running the make docs target.

@feanil feanil requested a review from bmtcril February 14, 2025 20:52
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how relevant the quality errors are, but this otherwise seems good

@feanil feanil merged commit 45f44c3 into master Feb 19, 2025
49 checks passed
@feanil feanil deleted the feanil/fix_docs_build branch February 19, 2025 14:27
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants