-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: Changes in xblock_v2 to support studio_view [FC-0076] #36029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrisChV
merged 11 commits into
openedx:master
from
open-craft:chris/advanced-editors-iframe
Jan 16, 2025
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
75cceef
feat: Send message when cancel button is clicked on xblock_v2 iframe
ChrisChV be646df
fix: add notify() to render in xblock_v2 to fix save block
ChrisChV f3a1163
Merge branch 'master' into chris/advanced-editors-iframe
ChrisChV 0025c19
refactor: Update xblock_iframe.html to intercep save/canel button eve…
ChrisChV f365c51
feat: Send block updated event on xblock_handler when is studio_submit
ChrisChV 57c76fa
feat: Update notify function to send save-end event and error event
ChrisChV 229d233
Merge branch 'master' into chris/advanced-editors-iframe
ChrisChV 3b2268d
refactor: Added send_block_updated_event in save_block
ChrisChV c05755c
refactor: Update code to send all events in notify using xblock-event…
ChrisChV 9f86ddc
refactor: Update preventDefault of events of cancel and save buttons
ChrisChV 1422fde
Merge branch 'master' into chris/advanced-editors-iframe
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.