-
Notifications
You must be signed in to change notification settings - Fork 4k
chore: use the PEP 508 format without editable VCS requirements #35654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @MoisesGSalas! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
3642cab
to
12a1963
Compare
@MoisesGSalas - hi there! Flagging that an additional test has popped up that needs to be run. @openedx/2u-arbi-bom flagging for review. |
12a1963
to
2cbd4d5
Compare
2cbd4d5
to
b15ee9c
Compare
This change makes it possible to use [uv](https://github.com/astral-sh/uv) as a pip replacement in order to perform a faster installation of requirements. `edx_proctoring_proctortrack` already publishes to PyPI (although the release with Django 4.2 support has not been published), so we don't need to install the package as editable because the MANIFEST.in file already includes all the necessary extra files.
b15ee9c
to
3f1ece7
Compare
@kdmccormick, I'm tagging you on this as I saw you were the one that discussed this package back in the Django 4.2 upgrade. I don't really know the implications of this package, but removing it was also on the table, right? It's still the only github requirement en edx-platform, and after a year the new version has not been published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right @MoisesGSalas . This package has been in github.in for far too long. I've created #36329 . Assuming that is accepted, let's just fully remove edx-proctoring-proctortrack on April 5th, in time for the Teak cutoff.
If for reason that DEPR proposal is rejected, then let's re-open this PR and proceed with converting it to a non-editable requirement.
Thanks!
Description
This change makes it possible to use uv as a pip replacement in order to perform a faster installation of requirements.
edx_proctoring_proctortrack
already publishes to PyPI (although the release with Django 4.2 support has not been published), so we don't need to install the package as editable because the MANIFEST.in file already includes all the necessary extra files.There was also the possibility of removing the package altogether, maybe we can make that push for the Sumak release?