Skip to content

Support learning MFE for notes toggle #23614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Support learning MFE for notes toggle #23614

merged 1 commit into from
Apr 9, 2020

Conversation

davestgermain
Copy link
Contributor

This PR:

  • removes calculator and notes buttons on the chromeless page, when viewed in the learning MFE
  • adds notes visibility to the courseware metadata API
  • supports toggling notes visibility from outside the unit iframe, by listening for a postMessage message

TNL-7163)

@davestgermain davestgermain requested a review from a team April 3, 2020 23:27
@davestgermain davestgermain mentioned this pull request Apr 3, 2020
Merged
davidjoy
davidjoy suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes only because of the defer thing mentioned above - I'm not quite sure why it was added or if it was supposed to be fixing something, but if anything the docs seem to say it shouldn't be used on a script without a src attribute. Otherwise I think this looks pretty good.

@davestgermain davestgermain requested a review from davidjoy April 7, 2020 17:39
@davestgermain
Copy link
Contributor Author

jenkins run all

@davestgermain
Copy link
Contributor Author

jenkins run all

@davestgermain davestgermain force-pushed the dcs/notes-toggle branch 2 times, most recently from b2059d0 to 8b4eeae Compare April 9, 2020 17:41
Added edxnotes information to the courseware API.
543611f 
Added notes visibility toggle support for courseware MFE.
Removed notes and calculator from chromeless view when rendered in courseware MFE.
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@davestgermain davestgermain merged commit b604770 into master Apr 9, 2020
@davestgermain davestgermain deleted the dcs/notes-toggle branch April 9, 2020 18:46
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@aliraza-abbasi aliraza-abbasi mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjoy davidjoy davidjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davestgermain @edx-status-bot @edx-pipeline-bot @davidjoy