fix(csi-node): handle devices for existing subsystems #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
Abhinandan-Purkait
approved these changes
Nov 30, 2024
sinhaashish
approved these changes
Dec 2, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
892: fix(csi-node): handle devices for existing subsystems r=tiagolobocastro a=tiagolobocastro When a device is broken but the volume is not unstaged properly, the subsytem ends up lingering in the system. If the device is staged again, the device is assined a different namespace id. Change the regex which is used in the device parameter fo account for this. Also extend the existing csi-node BDD testing. Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
When a device is broken but the volume is not unstaged properly, the subsytem ends up lingering in the system. If the device is staged again, the device is assined a different namespace id. Change the regex which is used in the device parameter fo account for this. Also extend the existing csi-node BDD testing. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
nvme-fixup
branch
from
18be1cf to
d831ac0
Compare
|
bors try |
tiagolobocastro
commented
Dec 3, 2024
tryBuild succeeded: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a device is broken but the volume is not unstaged properly, the subsytem ends up lingering in the system.
If the device is staged again, the device is assined a different namespace id. Change the regex which is used in the device parameter fo account for this. Also extend the existing csi-node BDD testing.