Skip to content

feat(topology): restrict users from deleting created-by label on pools #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sinhaashish
Copy link
Member

No description provided.

Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I wonder if we should have distinguished internal from user labels.
And don't show internal labels to the user, and don't let them delete them unless a flag is specified?
Maybe for now also don't return the created_by_dsp label for the gets

@sinhaashish sinhaashish force-pushed the restrict-deletion-created-by branch 2 times, most recently from 7cc812a to 7025cf6 Compare September 2, 2024 09:07
@sinhaashish sinhaashish force-pushed the restrict-deletion-created-by branch from 7025cf6 to 4c576cc Compare September 3, 2024 09:29
@sinhaashish sinhaashish force-pushed the restrict-deletion-created-by branch from 4c576cc to 37a3d84 Compare September 6, 2024 09:05
@sinhaashish
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 6, 2024
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <[email protected]>
@sinhaashish
Copy link
Member Author

bors ping

@bors-openebs-mayastor
Copy link

pong

@sinhaashish sinhaashish force-pushed the restrict-deletion-created-by branch from 37a3d84 to 65e5ce0 Compare September 6, 2024 11:18
@bors-openebs-mayastor
Copy link

Canceled.

@sinhaashish
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 423dab2 into openebs:develop Sep 6, 2024
4 checks passed
@sinhaashish sinhaashish deleted the restrict-deletion-created-by branch September 6, 2024 11:58
sinhaashish added a commit to sinhaashish/mayastor-control-plane that referenced this pull request Sep 6, 2024
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish



Co-authored-by: sinhaashish <[email protected]>
sinhaashish added a commit to sinhaashish/mayastor-control-plane that referenced this pull request Sep 6, 2024
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish

Co-authored-by: sinhaashish <[email protected]>
Signed-off-by: sinhaashish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants