-
Notifications
You must be signed in to change notification settings - Fork 39
feat(topology): restrict users from deleting created-by label on pools #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(topology): restrict users from deleting created-by label on pools #853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I wonder if we should have distinguished internal from user labels.
And don't show internal labels to the user, and don't let them delete them unless a flag is specified?
Maybe for now also don't return the created_by_dsp label for the gets
7cc812a
to
7025cf6
Compare
7025cf6
to
4c576cc
Compare
4c576cc
to
37a3d84
Compare
bors merge |
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish Co-authored-by: sinhaashish <[email protected]>
bors ping |
pong |
Signed-off-by: sinhaashish <[email protected]>
37a3d84
to
65e5ce0
Compare
Canceled. |
bors merge |
Build succeeded: |
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish Co-authored-by: sinhaashish <[email protected]>
853: feat(topology): restrict users from deleting created-by label on pools r=sinhaashish a=sinhaashish Co-authored-by: sinhaashish <[email protected]> Signed-off-by: sinhaashish <[email protected]>
No description provided.