fix(BD-labels):add device attributes and location details as bd labels

[Ab-hishek]

Signed-off-by: Abhishek Agarwal [email protected]

Why is this PR required? What issue does it fix?:
issue- #615

What this PR does?:
This PR adds some generic labels to the block device resources which are already present inside the BD CR spec along with some topology(location) details as labels for the block devices to be able to easily classify devices on the basis of these labels.

The labels will be added by making use of ndm configmap. The update that configmap requires is the addition of new field metaconfigs:

    # metconfig can be used to decorate the block device with different types of labels
    # that are available on the node or come in a device properties.
    # node labels - the node where bd is discovered. A whitlisted label prefixes
    # attribute labels - a property of the BD can be added as a ndm label as ndm.io/<property>=<property-value>
    metaconfigs:
      - key: node-labels
        name: node labels
        pattern:" kubernetes.io*,beta.kubernetes.io*"
      - key: device-labels
        name: device labels
        type: ".spec.details.vendor,.spec.details.model,.spec.details.driveType,.spec.filesystem.fsType"

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

1. Deleted ndm operator deployment and ndm manager daemonset.
2. Deployed fresh ndm resources.
3. Checked the BD resources labels after deployment. Verified that the device attribute labels and node location labels as getting added

master@master-virtual-machine:~$ kubectl describe bd blockdevice-0bbf3a32162c35d160379bdc5534f73a -n openebs
Name:         blockdevice-0bbf3a32162c35d160379bdc5534f73a
Namespace:    openebs
Labels:       beta.kubernetes.io/arch=amd64
              beta.kubernetes.io/os=linux
              kubernetes.io/arch=amd64
              kubernetes.io/hostname=node1-virtual-machine
              kubernetes.io/os=linux
              ndm.io/blockdevice-type=blockdevice
              ndm.io/driveType=HDD
              ndm.io/fsType=zfs_member
              ndm.io/managed=true
              ndm.io/model=Virtual_disk
              ndm.io/vendor=VMware
              nodename=node1-virtual-machine
Annotations:  internal.openebs.io/partition-uuid: 5ad22014-22bd-4b50-b3fc-46b77160d7ed
              internal.openebs.io/uuid-scheme: legacy
API Version:  openebs.io/v1alpha1
Kind:         BlockDevice
Spec:
  Capacity:
    Logical Sector Size:   512
    Physical Sector Size:  512
    Storage:               53686025728
  Details:
    Compliance:            SPC-
    Device Type:           partition
    Drive Type:            HDD
    Firmware Revision:     1.0 
    Hardware Sector Size:  512
    Logical Block Size:    512
    Model:                 Virtual_disk
    Physical Block Size:   512
    Serial:                
    Vendor:                VMware
  Devlinks:
    Kind:  by-path
    Links:
      /dev/disk/by-path/pci-0000:00:10.0-scsi-0:0:1:0-part1
  Filesystem:
    Fs Type:  zfs_member
  Node Attributes:
    Node Name:  node1-virtual-machine
  Partitioned:  No
  Path:         /dev/sdb1
Status:
  Claim State:  Unclaimed
  State:        Active
Events:         <none>

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

• Fixes Add device attributes and location details as labels to BD resources #615
• PR Title follows the convention of <type>(<scope>): <subject>
• Has the change log section been updated?
• Commit has unit tests
• Commit has integration tests
• (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
• (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

[lgtm-com]

This pull request introduces 1 alert when merging 8fdf4f5 into 426eeaa - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[lgtm-com]

This pull request introduces 2 alerts when merging 3ef8aa5 into 426eeaa - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[codecov-commenter]

Codecov Report

Merging #618 (77878d3) into develop (9fe3968) will decrease coverage by 1.22%.
The diff coverage is 15.29%.

@@             Coverage Diff             @@
##           develop     #618      +/-   ##
===========================================
- Coverage    46.09%   44.87%   -1.23%     
===========================================
  Files           78       79       +1     
  Lines         3820     3964     +144     
===========================================
+ Hits          1761     1779      +18     
- Misses        1901     2018     +117     
- Partials       158      167       +9     

Impacted Files	Coverage Δ
cmd/ndm_daemonset/controller/controller.go	13.18% <0.00%> (-1.45%)	⬇️
cmd/ndm_daemonset/controller/ndmconfig.go	73.33% <ø> (ø)
cmd/ndm_daemonset/probe/changehandler.go	0.00% <0.00%> (ø)
cmd/ndm_daemonset/controller/blockdevice.go	51.26% <11.32%> (-32.57%)	⬇️
cmd/ndm_daemonset/controller/blockdevicestore.go	71.42% <25.00%> (-1.49%)	⬇️
...md/ndm_daemonset/controller/sparsefilegenerator.go	81.01% <40.00%> (-2.99%)	⬇️
cmd/ndm_daemonset/probe/addhandler.go	67.97% <42.85%> (-3.36%)	⬇️
cmd/ndm_daemonset/probe/udevprobe.go	46.64% <50.00%> (-1.59%)	⬇️
pkg/partition/partition.go	30.26% <0.00%> (-11.56%)	⬇️
cmd/ndm_daemonset/probe/uuid.go	94.73% <0.00%> (-5.27%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe3968...77878d3. Read the comment docs.

[lgtm-com]

This pull request introduces 2 alerts when merging dca0b0f into 426eeaa - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request introduces 2 alerts when merging f274c21 into 426eeaa - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[lgtm-com]

This pull request introduces 2 alerts when merging ad03f13 into 426eeaa - view on LGTM.com

new alerts:

• 2 for Useless assignment to local variable

[akhilerm]

@a4abhishek a few more nitpick comments.

[akhilerm]

LGTM, just a comment on the generated operator file

[akhilerm]

LGTM

[akhilerm]

LGTM.

Need to add a reference link to the original code from the k8s repo

[akhilerm]

LGTM

[z0marlin]

LGTM. Thanks for working on this.