Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add integ security tests with a limited user #313

Conversation

skkosuri-amzn
Copy link
Contributor

Issue #, if available:
Add integ security tests with a limited user

Description of changes:
So far security tests are run with admin user. In additional to running all tests as admin user, this PR adds tests which are run with a user with limited permissions.

./gradlew :alerting:integTestRunner -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=es-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin -Dsecurity=true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #313 (b5a272a) into master (7694fd0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
+ Coverage     79.27%   79.30%   +0.02%     
  Complexity      202      202              
============================================
  Files           151      151              
  Lines          5322     5324       +2     
  Branches        701      701              
============================================
+ Hits           4219     4222       +3     
+ Misses          730      728       -2     
- Partials        373      374       +1     
Impacted Files Coverage Δ Complexity Δ
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (ø) 0.00% <0.00%> (ø%)
...erting/transport/TransportGetDestinationsAction.kt 76.38% <0.00%> (+0.33%) 0.00% <0.00%> (ø%)
...rch/alerting/transport/TransportGetAlertsAction.kt 75.75% <0.00%> (+0.37%) 0.00% <0.00%> (ø%)
...distroforelasticsearch/alerting/core/JobSweeper.kt 72.19% <0.00%> (+0.53%) 35.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7694fd0...b5a272a. Read the comment docs.

Copy link
Contributor

@lezzago lezzago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nitpicks

@skkosuri-amzn skkosuri-amzn merged commit 1bb2698 into opendistro-for-elasticsearch:master Dec 2, 2020
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
* Add integ security tests with a limited user

* Fixed README

* Minor formating changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants