This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Add integ security tests with a limited user #313
Merged
skkosuri-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
skkosuri-amzn:integ-sec-test
Dec 2, 2020
Merged
Add integ security tests with a limited user #313
skkosuri-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
skkosuri-amzn:integ-sec-test
Dec 2, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
============================================
+ Coverage 79.27% 79.30% +0.02%
Complexity 202 202
============================================
Files 151 151
Lines 5322 5324 +2
Branches 701 701
============================================
+ Hits 4219 4222 +3
+ Misses 730 728 -2
- Partials 373 374 +1
Continue to review full report at Codecov.
|
lezzago
reviewed
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor nitpicks
alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/ODFERestTestCase.kt
Show resolved
Hide resolved
.../kotlin/com/amazon/opendistroforelasticsearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/amazon/opendistroforelasticsearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Outdated
Show resolved
Hide resolved
lezzago
approved these changes
Dec 2, 2020
qreshi
approved these changes
Dec 2, 2020
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Add integ security tests with a limited user * Fixed README * Minor formating changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add integ security tests with a limited user
Description of changes:
So far security tests are run with admin user. In additional to running all tests as admin user, this PR adds tests which are run with a user with limited permissions.
./gradlew :alerting:integTestRunner -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=es-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin -Dsecurity=true
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.