Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Misc fixes for 1.11 release #274

Merged

Conversation

skkosuri-amzn
Copy link
Contributor

Issue #, if available:
Misc fixes.
Description of changes:

  1. Delete dead code,
  2. Fixed flaky tests.
  3. Reverted to runBlocking for monitor runner.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #274 into master will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #274      +/-   ##
============================================
- Coverage     80.22%   79.71%   -0.51%     
+ Complexity      196      192       -4     
============================================
  Files           150      150              
  Lines          5132     5132              
  Branches        661      661              
============================================
- Hits           4117     4091      -26     
- Misses          655      680      +25     
- Partials        360      361       +1     
Impacted Files Coverage Δ Complexity Δ
...rch/alerting/transport/TransportGetAlertsAction.kt 72.60% <ø> (ø) 0.00 <0.00> (ø)
...endistroforelasticsearch/alerting/MonitorRunner.kt 76.31% <100.00%> (-0.44%) 0.00 <0.00> (ø)
...arch/alerting/core/schedule/JobSchedulerMetrics.kt 62.50% <0.00%> (-18.75%) 4.00% <0.00%> (-2.00%)
...rch/alerting/core/action/node/ScheduledJobStats.kt 55.55% <0.00%> (-11.12%) 3.00% <0.00%> (-1.00%)
...roforelasticsearch/alerting/alerts/AlertIndices.kt 66.14% <0.00%> (-9.45%) 0.00% <0.00%> (ø%)
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) 7.00% <0.00%> (-1.00%)
...asticsearch/alerting/core/schedule/JobScheduler.kt 71.42% <0.00%> (-4.29%) 15.00% <0.00%> (ø%)
...distroforelasticsearch/alerting/core/JobSweeper.kt 71.65% <0.00%> (-0.54%) 35.00% <0.00%> (ø%)
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043ba5c...e2fe1e1. Read the comment docs.

@skkosuri-amzn skkosuri-amzn merged commit f1b7375 into opendistro-for-elasticsearch:master Oct 18, 2020
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
* delete dead code, fix flaky tests, revert to runBlocking for monitor runner
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants