Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Adds more alert properties to templateArgs for context variable #26

Merged
1 commit merged into from
Apr 17, 2019
Merged

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Apr 5, 2019

Issue #, if available:
#25

Description of changes:
This adds new alert properties to the alert templateArgs method which is used when creating the context variable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jinsoor-amzn jinsoor-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested review from a user and removed request for a user April 8, 2019 04:54
@ghost ghost requested review from a user and removed request for lucaswin-amzn April 17, 2019 09:56
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to ensure that all alert fields are automatically exposed to the mustache template, the same way that it works for Painless. I've filed the followup issue #34 for this.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants