This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Add action to create /_alerting/destinations/ #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to OpenDistro version 1.7.0
* Adds support for ES 7.7.0 * Update the Release Notes * Update the requirement of JDK 14 in README * Update the Java version in 'push-notification-jar' workflow
* change default value of the setting 'alert_history_max_age' to 30 days * change default value of the setting 'alert_history_retention_period' to 60 days
- Use Codecov to visualize the code coverage result - Add Coverage Report Upload action in test-workflow - Add several badges in README
) * Issue #232 : Add action to /_alerting/monitor/{id}, /_alerting/monitor/_search
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
============================================
+ Coverage 76.30% 76.96% +0.65%
+ Complexity 162 157 -5
============================================
Files 71 75 +4
Lines 2672 2809 +137
Branches 422 430 +8
============================================
+ Hits 2039 2162 +123
- Misses 415 428 +13
- Partials 218 219 +1
Continue to review full report at Codecov.
|
lezzago
suggested changes
Aug 13, 2020
Comment on lines
28
to
33
| var destinationId: String | ||
| var seqNo: Long | ||
| var primaryTerm: Long | ||
| var refreshPolicy: WriteRequest.RefreshPolicy | ||
| var method: RestRequest.Method | ||
| var destination: Destination |
There was a problem hiding this comment.
Should we be making all the attributes to the request immutable by using val?
Comment on lines
33
to
38
| var id: String | ||
| var version: Long | ||
| var seqNo: Long | ||
| var primaryTerm: Long | ||
| var status: RestStatus | ||
| var destination: Destination |
There was a problem hiding this comment.
Should these be immutable as well since we would not want to modify them after the response is generated.
Comment on lines
67
to
81
| } else { | ||
| if (!IndexUtils.scheduledJobIndexUpdated) { | ||
| IndexUtils.updateIndexMapping(ScheduledJob.SCHEDULED_JOBS_INDEX, ScheduledJob.SCHEDULED_JOB_TYPE, | ||
| ScheduledJobIndices.scheduledJobMappings(), clusterService.state(), client.admin().indices(), | ||
| object : ActionListener<AcknowledgedResponse> { | ||
| override fun onResponse(response: AcknowledgedResponse) { | ||
| onUpdateMappingsResponse(response) | ||
| } | ||
| override fun onFailure(t: Exception) { | ||
| actionListener.onFailure(t) | ||
| } | ||
| }) | ||
| } else { | ||
| prepareDestinationIndexing() | ||
| } |
There was a problem hiding this comment.
Can you change the if block to else if, so we wont have any nested if else statements?
There was a problem hiding this comment.
Good catch, changed.
lezzago
approved these changes
Aug 14, 2020
ftianli-amzn
approved these changes
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#232
Description of changes:
#232
Failures responses are also standardized.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.