This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Add action to DELETE /_alerting/destinations/{id} #233
Merged
skkosuri-amzn
merged 9 commits into
opendistro-for-elasticsearch:master
from
skkosuri-amzn:master
Aug 11, 2020
Merged
Add action to DELETE /_alerting/destinations/{id} #233
skkosuri-amzn
merged 9 commits into
opendistro-for-elasticsearch:master
from
skkosuri-amzn:master
Aug 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing/destinations/{id}
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
============================================
+ Coverage 76.14% 76.24% +0.10%
- Complexity 157 162 +5
============================================
Files 63 66 +3
Lines 2586 2635 +49
Branches 402 420 +18
============================================
+ Hits 1969 2009 +40
+ Misses 421 412 -9
- Partials 196 214 +18 Continue to review full report at Codecov.
|
qreshi
reviewed
Aug 7, 2020
...main/kotlin/com/amazon/opendistroforelasticsearch/alerting/action/DeleteDestinationAction.kt
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/alerting/transport/TransportDeleteDestinationAction.kt
Outdated
Show resolved
Hide resolved
dbbaughe
approved these changes
Aug 11, 2020
qreshi
approved these changes
Aug 11, 2020
|
||
var destinationID: String? = null | ||
var refreshPolicy: WriteRequest.RefreshPolicy? = null | ||
val destinationId: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP: I believe the old naming scheme was more appropriate since we typically only begin lowercasing acronyms when they exceed two letters.
This is not a blocker for this PR, we can always change it in another one of the API PRs.
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Issue #232 : Add action to DELETE /_alerting/destinations/{id}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#232
Description of changes:
Refer: #232
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.