Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add http proxy support to outgoing notifcations #23

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Conversation

imranh2
Copy link
Contributor

@imranh2 imranh2 commented Apr 4, 2019

Add proxy support for outgoing notifications by looking at system properties.

Issue: #22

Description of changes: Simply call useSystemProperties() which then finds and uses properties such as http.proxyHost, http.proxyPort, https.proxyHost...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this support.

Verified existing tests pass and able to send Chime notifications

Copy link
Contributor

@lucaswin-amzn lucaswin-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vamshin vamshin merged commit 335a8b4 into opendistro-for-elasticsearch:master Apr 9, 2019
@tomerilp
Copy link

Hi,
Is there any documentation on how to configure Slack notification with those proxy parameters?
Where exactly should I configure the proxy?

Thanks,

@imranh2
Copy link
Contributor Author

imranh2 commented Jun 20, 2019

@tomerilp,

Always multiple ways to set proxy environment variables, but whatever suits you you

I ended up setting it system wide for java /etc/java-8-openjdk/net.properties as we isolate the entire node to one role and can track every outgoing http request.

@tomerilp
Copy link

tomerilp commented Jun 30, 2019

@tomerilp,

Always multiple ways to set proxy environment variables, but whatever suits you you

I ended up setting it system wide for java /etc/java-8-openjdk/net.properties as we isolate the entire node to one role and can track every outgoing http request.

I managed to make it work by adding ES_JAVA_OPTS="-Dhttps.proxyHost=proxy.domain.com -Dhttps.proxyPort=8080" to /etc/sysconfig/elasticsearch
I wonder if it possible to apply these settings only on the plugin scope so it won't affect the entire elasticsearch.

Thanks,

tlfeng pushed a commit that referenced this pull request Feb 6, 2021
…Client (#23)

Add http proxy support to outgoing notifications
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants