-
Notifications
You must be signed in to change notification settings - Fork 79
Upgrade to ES 6.7 #19
Upgrade to ES 6.7 #19
Conversation
@@ -278,7 +278,6 @@ abstract class AlertingRestTestCase : ESRestTestCase() { | |||
override fun restClientSettings(): Settings { | |||
return if (isDebuggingTest || isDebuggingRemoteCluster) { | |||
Settings.builder() | |||
.put(CLIENT_RETRY_TIMEOUT, TimeValue.timeValueMinutes(10)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we increase the connect timeout as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What connect timeout do you mean? Do you mean CLIENT_SOCKET_TIMEOUT
? That is already at 10 min. I don't know if we need to increase it.
@jinsoor-amzn Could you update the result of Integration tests ? |
This is the output of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinsoor-amzn Thanks for the details.
Changes LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the change!
* Upgrade to ES 6.7 * use ES 6.7.1
Description of changes:
Upgrade to ES 6.7.1 and Gradle 5.2.1 (upstream Gradle version used by ES 6.7)
Scheduler.schedule
has been deprecated.Scheduler.ScheduledFuture<?> schedule(TimeValue delay, String executor, Runnable command)
has been deprecated and replace toScheduledCancellable schedule(Runnable command, TimeValue delay, String executor)
. Related: elastic/elasticsearch@68ed72b#diff-0e2c2d1682285e7920440dbc4a5a49bfClient RetryTimeout is removed.
This was being used in the unit test in Alerting and it is not longer supported. Related elastic/elasticsearch@99192e7#diff-ffbc192f9ee093f558b3b55dcdc2d63f
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.