-
Notifications
You must be signed in to change notification settings - Fork 184
[rhoai] RHOAIENG-25111: Update KServe RBAC for autoscaling using KEDA #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rhoai
Are you sure you want to change the base?
[rhoai] RHOAIENG-25111: Update KServe RBAC for autoscaling using KEDA #1989
Conversation
The `odh-model-controller` requires permissions to manipulate KEDA resources as well as create roles to give KServe access to metrics in Prometheus. Refs: - RHOAIENG-25111: https://issues.redhat.com//browse/RHOAIENG-25111 - opendatahub-io/odh-model-controller#452 Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1989 +/- ##
=======================================
Coverage 27.22% 27.22%
=======================================
Files 171 171
Lines 12040 12040
=======================================
Hits 3278 3278
Misses 8470 8470
Partials 292 292 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #1986
/assign zdtsw
wait a bit to merge till we fully tested in ODH