Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(gha): switch image build to ubuntu-24.04 as there is more disk space available #970

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 19, 2025

Description

There is less stuff preinstalled now

The changes themselves were highlighted in

How Has This Been Tested?

Before

https://github.com/jiridanek/notebooks/actions/runs/13950814007/job/39049648105#step:8:57

Filesystem                   Size  Used Avail Use% Mounted on
/dev/root                     73G   69G  4.1G  95% /
tmpfs                        7.9G  172K  7.9G   1% /dev/shm
tmpfs                        3.2G  1.2M  3.2G   1% /run
tmpfs                        5.0M     0  5.0M   0% /run/lock
/dev/sdb15                   105M  6.1M   99M   6% /boot/efi
/dev/sda1                     74G   70G  100M 100% /mnt
tmpfs                        1.6G   12K  1.6G   1% /run/user/1001
/dev/mapper/buildvg-buildlv  105G   24K  105G   1% /home/runner/.local/share/containers
               total        used        free      shared  buff/cache   available
Mem:            15Gi       630Mi        11Gi        [62](https://github.com/jiridanek/notebooks/actions/runs/13950814007/job/39049648105#step:8:63)Mi       3.2Gi        14Gi
Swap:          4.0Gi          0B       4.0Gi

With this change

https://github.com/jiridanek/notebooks/actions/runs/13952851356/job/39056607887#step:8:57

Filesystem                   Size  Used Avail Use% Mounted on
/dev/root                     72G   68G  4.1G  95% /
tmpfs                        7.9G   84K  7.9G   1% /dev/shm
tmpfs                        3.2G  1.1M  3.2G   1% /run
tmpfs                        5.0M     0  5.0M   0% /run/lock
/dev/sda16                   881M   [59](https://github.com/jiridanek/notebooks/actions/runs/13952851356/job/39056607887#step:8:60)M  761M   8% /boot
/dev/sda15                   105M  6.1M   99M   6% /boot/efi
/dev/sdb1                     74G   70G  100M 100% /mnt
tmpfs                        1.6G   12K  1.6G   1% /run/user/1001
/dev/mapper/buildvg-buildlv  107G   24K  107G   1% /home/runner/.local/share/containers
               total        used        free      shared  buff/cache   available
Mem:            15Gi       995Mi        12Gi        [61](https://github.com/jiridanek/notebooks/actions/runs/13952851356/job/39056607887#step:8:62)Mi       2.3Gi        14Gi
Swap:          4.0Gi          0B       4.0Gi

This is +2G of disk space! Hmm, meh.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jstourac and paulovmr March 19, 2025 17:26
@openshift-ci openshift-ci bot added the size/xs label Mar 19, 2025
@jstourac
Copy link
Member

/lgtm
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/lgtm
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 19, 2025
@jiridanek
Copy link
Member Author

Next step, investigate what else can be deleted and delete that too, we should be able to get about 10G more

@jiridanek
Copy link
Member Author

hopefully this won't break anything when it is propagated to rhds/notebooks repo

/approve

@jiridanek jiridanek closed this Mar 19, 2025
@jiridanek jiridanek reopened this Mar 19, 2025
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6f701fe into opendatahub-io:main Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants