-
Notifications
You must be signed in to change notification settings - Fork 95
feat(upgrade): bi-annual RStudio package update #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade): bi-annual RStudio package update #965
Conversation
Skipping CI for Draft Pull Request. |
4793443
to
bc46386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy, added only a question, apart of this /lgtm
bc46386
to
8b811e5
Compare
This commit is related to the ongoing work to release the `2025a` software upgrade. Upgrades: - `R` - `4.4.1` -> `4.4.3` - `RStudio` - rstudio-server-rhel-2024.04.2-764-x86_64.rpm -> rstudio-server-rhel-2024.12.1-563-x86_64.rpm - `tidymodels` - `1.2.0` -> `1.3.0` - `plumber` - `1.2.2` -> `1.3.0` A couple other "quality of life" improvements were included: - Refactored `Dockerfile` to combine `RUN` statements where obvious/low-risk - Better use of `ARG` references to reduce copy-pasta in `Dockerfile` instructions - `install_packages.R` script externalizes the userland software installs in an external script to better "share" across `cpu` + `cuda` `Dockerfile` variants - Fixed issue(s) with `kustomize` `cuda` `overlay` so now `kubectl apply -k overlays/accelerator/cuda` works Related-to: https://issues.redhat.com/browse/RHOAIENG-19484
8b811e5
to
253e0d9
Compare
/override "ci/prow/images" "ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror" more examples of https://issues.redhat.com/browse/OCPBUGS-50507 that continues to plague us 😢 |
@andyatmiami: Overrode contexts on behalf of andyatmiami: ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror, ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "ci/prow/images" "ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror" "ci/prow/rstudio-notebook-e2e-tests" |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/cuda-rstudio-c9s-python-3-11-pr-image-mirror, ci/prow/images, ci/prow/rstudio-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "ci/prow/rstudio-c9s-python-3-11-pr-image-mirror" |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/rstudio-c9s-python-3-11-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5bb0809
into
opendatahub-io:main
Description
This commit is related to the ongoing work to release the
2025a
software upgrade.Upgrades:
R
4.4.1
->4.4.3
RStudio
tidymodels
1.2.0
->1.3.0
plumber
1.2.2
->1.3.0
A couple other "quality of life" improvements were included:
Dockerfile
to combineRUN
statements where obvious/low-riskARG
references to reduce copy-pasta inDockerfile
instructionsinstall_packages.R
script externalizes the userland software installs in an external script to better "share" acrosscpu
+cuda
Dockerfile
variantskustomize
cuda
overlay
so nowkubectl apply -k overlays/accelerator/cuda
worksRelated-to: https://issues.redhat.com/browse/RHOAIENG-19484
How Has This Been Tested?
Verification was performed in the following manner:
nodeSelector
added to ensure workload deployed on worker node with GPUemptyDir
volume added to mimic production usagePermission Denied
errors related to/opt/app-root/src/.cache
deploy%
target ofMakefile
used to deploy imageundeploy%
target ofMakefile
used to undeploy image / prepare environment for next imageSimply to better equate myself with
R
- I also ran this simple script within the pod to confirm versions of dependencies installed:(app-root) bash-5.1$ cat test_versions.R
(app-root) bash-5.1$ Rscript test_versions.R
Merge criteria: